Ticket #108 (closed defect: fixed)

Opened 2 years ago

Last modified 1 month ago

Error in limiting crop bounds

Reported by: harri Owned by: harri
Priority: major Milestone: 0.5.future
Component: imginfo Version: 0.3.0
Keywords: Cc:
Test Case Result:

Description

In PhotoInfo#checkCropBounds?() there is a check that tries to verify that max bound is larger than min bound:

        if ( cropMaxX - cropMinX <= 0.0) {
            cropMaxX = 1.0 - cropMinX;
        }

Obviously this does not work, probably the correct way would be to swap the max and min values.

Change History

follow-up: ↓ 2   Changed 2 years ago by harri

  • status changed from new to assigned

Fixed in trunk in r666, to be decided whether to port to 0.4.x

in reply to: ↑ 1   Changed 2 years ago by harri

Replying to harri:

Fixed in trunk in r666, to be decided whether to port to 0.4.x

Correct version is r667

  Changed 1 month ago by harri

  • status changed from assigned to closed
  • testcase_result deleted
  • resolution set to fixed
Note: See TracTickets for help on using tickets.